the_og/better-claude-config
1
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases 5 Wiki Activity

feat(#93): filesystem permission pre-flight (0600/0700) + one-click fix (P1) #99

Closed
the_og wants to merge 2 commits from feat/93 into feat/91
pull from: feat/93
merge into: :feat/91
Conversation 0 Commits 2 Files Changed 3
+307
2 Commits
Author SHA1 Message Date
Cowork SupervisorandClaude Opus 4.8 603d24566d test(#93): key injected mode/chmod maps on as_posix() for the Windows runner
CI / Lint (ruff) (pull_request) Successful in 9s
Details
CI / Tests (py3.12 / windows-latest) (pull_request) Successful in 23s
Details
CI / Tests (py3.10 / ubuntu-latest) (pull_request) Successful in 12s
Details
CI / Tests (py3.12 / ubuntu-latest) (pull_request) Successful in 16s
Details
CI / Tests (py3.13 / ubuntu-latest) (pull_request) Successful in 13s
Details
CI / Catalog signature (pull_request) Successful in 8s
Details 
permission_status/fix_permissions wrap paths in the running OS's Path class, so
on the windows-latest CI job str(p) uses backslashes and the fixture dict lookups
miss — the same portability trap fixed for #91. Normalise with Path(p).as_posix()
in the four affected lambdas. Pure test fix; production code unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-08-12 03:14:16 -04:00
Cowork SupervisorandClaude Opus 4.8 0b2827e6b8 feat(#93): filesystem permission pre-flight for credential configs (0600/0700)
CI / Tests (py3.10 / ubuntu-latest) (pull_request) Successful in 13s
Details
CI / Tests (py3.12 / ubuntu-latest) (pull_request) Successful in 13s
Details
CI / Lint (ruff) (pull_request) Successful in 8s
Details
CI / Tests (py3.12 / windows-latest) (pull_request) Failing after 24s
Details
CI / Tests (py3.13 / ubuntu-latest) (pull_request) Successful in 12s
Details
CI / Catalog signature (pull_request) Successful in 8s
Details 
ssh-mcp refuses to start if its config is group/world-readable (mode & 0o077 →
throws, requiring dir 0700 / file 0600). A GUI user has no idea what chmod 600
means — they just get a dead server. This checks it and offers a one-click fix.

Core (pure, POSIX-only, injectable stat/chmod so tests never touch a real file):
- permission_status(path): the ssh-mcp rule — any group/other bit set (mode & 0o077)
  is not-ok; file must be 0600, its dir 0700. Returns None on Windows (modes don't
  apply) or when the file is absent (nothing to pre-flight). Plain-language problems
  naming the offending octal mode.
- fix_permissions(path): chmod file → 0600, dir → 0700. No-op on Windows; reports
  an OSError instead of raising.
- sidecar_permission_warnings() / sidecar_permission_fix_target(): tie the check to
  #91's sidecar path resolution so it knows WHICH file to inspect. Mirror the
  sidecar-warnings shape.

GUI: a warning label + "Fix permissions" button in the stdio editor (mirrors the
removed-flag surface), shown only when the sidecar exists and is too open. Hidden
on Windows and for non-sidecar servers. Smoke-tested headlessly.

pytest green (529 passed), ruff + format clean. Closes #93. Part of epic #94.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-08-12 03:10:29 -04:00