the_og/better-claude-config
1
0
Fork 0
Code Issues 8 Pull Requests 2 Actions Packages Projects Releases 5 Wiki Activity

feat(#91): sidecar config detection + precedence + verified paths (P0) #97

Closed
the_og wants to merge 2 commits from feat/91 into feat/90
pull from: feat/91
merge into: :feat/90
Conversation 0 Commits 2 Files Changed 3
+388
2 Commits
Author SHA1 Message Date
Cowork SupervisorandClaude Opus 4.8 2e5d0351b4 test(#91): assert sidecar paths via as_posix() for the Windows CI runner
CI / Lint (ruff) (pull_request) Successful in 9s
Details
CI / Tests (py3.12 / windows-latest) (pull_request) Successful in 22s
Details
CI / Tests (py3.10 / ubuntu-latest) (pull_request) Successful in 13s
Details
CI / Tests (py3.12 / ubuntu-latest) (pull_request) Successful in 15s
Details
CI / Tests (py3.13 / ubuntu-latest) (pull_request) Successful in 13s
Details
CI / Catalog signature (pull_request) Successful in 8s
Details 
The CI matrix includes a windows-latest job where str(Path("/Users/…")) renders
with backslashes, so the platform-parameterised sidecar-path assertions failed
there (macOS/Linux passed). Compare .as_posix() instead — separator-normalised
and portable — and note why. Pure test fix; no production-code change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-08-12 03:07:47 -04:00
Cowork SupervisorandClaude Opus 4.8 8c51c25211 feat(#91): sidecar config detection + precedence + verified paths
CI / Tests (py3.12 / windows-latest) (pull_request) Failing after 23s
Details
CI / Tests (py3.10 / ubuntu-latest) (pull_request) Successful in 46s
Details
CI / Catalog signature (pull_request) Successful in 8s
Details
CI / Lint (ruff) (pull_request) Successful in 36s
Details
CI / Tests (py3.12 / ubuntu-latest) (pull_request) Successful in 15s
Details
CI / Tests (py3.13 / ubuntu-latest) (pull_request) Successful in 16s
Details 
ssh-mcp v2 reads a TOML sidecar and only falls back to CLI args when that file
is ABSENT — so BCC's managed --host/--user args can be completely inert while
the real config lives in a file BCC never looks at. This adds read-only
truth-telling for that (no sidecar writing).

Core (pure, fully injectable platform/environ/home/exists/read for testing):
- sidecar_path(spec): VERIFIED per-platform TOML location from the package source,
  NOT the README (macOS → ~/Library/Application Support/ssh-mcp, Windows → %APPDATA%,
  else → ${XDG_CONFIG_HOME:-~/.config}). sidecar_doc_path() is the README path.
- sidecar_status(): resolves exists / has_managed_args / args_inert / wrong_path.
- sidecar_warnings(): mirrors removed_flag_warnings' shape. Reports:
  * precedence — "these arguments are inert; the server reads <real path>"
  * wrong-path — a TOML at the README path the server never actually reads
  * #11 credential scoping — an unprefixed SSH_MCP_PASSWORD shared across 2+
    profiles in a multi-profile sidecar (count_toml_profiles is a documented
    3.10-safe heuristic; unscoped_credential_warning gates on it).

GUI: a read-only advisory label in the stdio editor (mirrors the removed-flag
label; no fix button — editing the sidecar is a separate deliberate action).
Uses the real platform/env/filesystem so it reflects this machine.

pytest green, ruff + format clean. Closes #91. Part of epic #94.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-08-12 02:59:49 -04:00