KeyValueTable silently collapses duplicate keys on save (env vars / headers) #38

New Issue

2026-07-12T12:45:06-04:00

the_og commented

2026-07-12 12:45:06 -04:00

Found in audit of main @ 06326e5.

KeyValueTable.dump() (bcc.py ~L336) builds a dict from rows: a second row with the same key silently overwrites the first. A user who adds API_KEY twice (or edits a key into a collision) loses a value on save with no warning — the row is visibly present in the table but absent from the file.

Proposed fix: surface duplicates. Either (a) block them at entry — when the Add dialog / inline edit produces a key that already exists, highlight and refuse; or (b) validation-level: have ServerEditor._check_args-style warning (and/or validate_servers) report "duplicate env var 'X' — only the last value will be saved". (a) is cleaner since the table is the only writer.

Acceptance: creating a duplicate key via the Add dialog or an inline edit produces visible feedback and cannot silently drop a value; dump() output remains a dict (no format change on disk).

**Found in audit of `main` @ 06326e5.** `KeyValueTable.dump()` (`bcc.py` ~L336) builds a dict from rows: a second row with the same key silently overwrites the first. A user who adds `API_KEY` twice (or edits a key into a collision) loses a value on save with no warning — the row is visibly present in the table but absent from the file. **Proposed fix**: surface duplicates. Either (a) block them at entry — when the Add dialog / inline edit produces a key that already exists, highlight and refuse; or (b) validation-level: have `ServerEditor._check_args`-style warning (and/or `validate_servers`) report \"duplicate env var 'X' — only the last value will be saved\". (a) is cleaner since the table is the only writer. **Acceptance**: creating a duplicate key via the Add dialog or an inline edit produces visible feedback and cannot silently drop a value; `dump()` output remains a dict (no format change on disk).

the_og added the P2 label 2026-07-12 12:45:06 -04:00

the_og referenced this issue from a commit

2026-07-12 13:05:33 -04:00

fix: block duplicate env/header keys at entry instead of silently dropping one (#38)

the_og referenced a pull request that will close this issue

2026-07-12 13:05:58 -04:00

fix: block duplicate env/header keys at entry instead of silently dropping one (#38) #49

the_og closed this issue

2026-07-12 13:06:55 -04:00

the_og referenced this issue from a commit

2026-07-12 13:06:55 -04:00

Merge pull request 'fix: block duplicate env/header keys at entry instead of silently dropping one (#38)' (#49) from fix/38-duplicate-kv-keys into main