On Windows, proc.kill() only kills the direct child (e.g. npx), not grandchildren (node, the actual server). This is the same concern family as issue #9 (Restart Claude Desktop) — blanket process-tree termination on Windows needs careful scoping to avoid killing unrelated processes.
Options to explore:
taskkill /T /F /PID <pid> for tree-kill on Windows
subprocess.CREATE_NEW_PROCESS_GROUP + os.kill(proc.pid, signal.CTRL_BREAK_EVENT) as a gentler alternative
Constraint: Cannot test locally on macOS. Any fix needs a Windows CI matrix job or manual verification note in the PR.
Cross-reference: issue #9 (Restart Claude Desktop) has the same Windows process-targeting concern.
Follow-up from PR #11 supervisor review (item 4).
On Windows, `proc.kill()` only kills the direct child (e.g. `npx`), not grandchildren (`node`, the actual server). This is the same concern family as issue #9 (Restart Claude Desktop) — blanket process-tree termination on Windows needs careful scoping to avoid killing unrelated processes.
**Options to explore:**
- `taskkill /T /F /PID <pid>` for tree-kill on Windows
- `subprocess.CREATE_NEW_PROCESS_GROUP` + `os.kill(proc.pid, signal.CTRL_BREAK_EVENT)` as a gentler alternative
**Constraint:** Cannot test locally on macOS. Any fix needs a Windows CI matrix job or manual verification note in the PR.
Cross-reference: issue #9 (Restart Claude Desktop) has the same Windows process-targeting concern.
the_og
added the P1 label 2026-07-02 01:05:57 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follow-up from PR #11 supervisor review (item 4).
On Windows,
proc.kill()only kills the direct child (e.g.npx), not grandchildren (node, the actual server). This is the same concern family as issue #9 (Restart Claude Desktop) — blanket process-tree termination on Windows needs careful scoping to avoid killing unrelated processes.Options to explore:
taskkill /T /F /PID <pid>for tree-kill on Windowssubprocess.CREATE_NEW_PROCESS_GROUP+os.kill(proc.pid, signal.CTRL_BREAK_EVENT)as a gentler alternativeConstraint: Cannot test locally on macOS. Any fix needs a Windows CI matrix job or manual verification note in the PR.
Cross-reference: issue #9 (Restart Claude Desktop) has the same Windows process-targeting concern.