the_og/better-claude-config
1
0
Fork 0
Code Issues 8 Pull Requests 3 Actions Packages Projects Releases 4 Wiki Activity

spawn-test: Windows process-tree kill is best-effort (follow-up #9) #13

New Issue
Closed
opened 2026-07-02 01:05:57 -04:00 by the_og · 0 comments
the_og commented 2026-07-02 01:05:57 -04:00
Owner
Copy Link
Copy Source

Follow-up from PR #11 supervisor review (item 4).

On Windows, proc.kill() only kills the direct child (e.g. npx), not grandchildren (node, the actual server). This is the same concern family as issue #9 (Restart Claude Desktop) — blanket process-tree termination on Windows needs careful scoping to avoid killing unrelated processes.

Options to explore:

  • taskkill /T /F /PID <pid> for tree-kill on Windows
  • subprocess.CREATE_NEW_PROCESS_GROUP + os.kill(proc.pid, signal.CTRL_BREAK_EVENT) as a gentler alternative

Constraint: Cannot test locally on macOS. Any fix needs a Windows CI matrix job or manual verification note in the PR.

Cross-reference: issue #9 (Restart Claude Desktop) has the same Windows process-targeting concern.

Follow-up from PR #11 supervisor review (item 4). On Windows, `proc.kill()` only kills the direct child (e.g. `npx`), not grandchildren (`node`, the actual server). This is the same concern family as issue #9 (Restart Claude Desktop) — blanket process-tree termination on Windows needs careful scoping to avoid killing unrelated processes. **Options to explore:** - `taskkill /T /F /PID <pid>` for tree-kill on Windows - `subprocess.CREATE_NEW_PROCESS_GROUP` + `os.kill(proc.pid, signal.CTRL_BREAK_EVENT)` as a gentler alternative **Constraint:** Cannot test locally on macOS. Any fix needs a Windows CI matrix job or manual verification note in the PR. Cross-reference: issue #9 (Restart Claude Desktop) has the same Windows process-targeting concern.
the_og added the P1 label 2026-07-02 01:05:57 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0
P1
P2
blocked
Waiting on an external thing before it can move.
 decision
A decision record (D-007 style) — settled call, referenceable by number from any repo.
 needs-decision
Waiting on AJ's call.
 next
Current focus / next actionable item.
 status
The single pinned STATUS issue for this repo — live state, next action, open items, decisions needed.
No Label P1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
the_og
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: the_og/better-claude-config#13
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?