spawn-test: bump timeout constants to avoid CI flakiness #12

New Issue

2026-07-02T01:05:57-04:00

the_og commented

2026-07-02 01:05:57 -04:00

Follow-up from PR #11 supervisor review (item 3).

The crashed/exited tests use 0.3–0.5 s timeouts, which can misfire on a slow CI runner where Python interpreter startup takes longer than expected (a subprocess that takes >300 ms to start would time out and be classified "ok" instead of "crashed"/"exited").

Fix: Bump the timeout argument in the non-"ok" spawn test cases from 0.3–0.5 s to 1–2 s. The "ok" (timeout) path can stay at 0.3 s since timing out means success there.

Relevant tests: test_spawn_test_crashed, test_spawn_test_exited_cleanly, test_spawn_test_stderr_captured in tests/test_core.py.

Follow-up from PR #11 supervisor review (item 3). The crashed/exited tests use 0.3–0.5 s timeouts, which can misfire on a slow CI runner where Python interpreter startup takes longer than expected (a subprocess that takes >300 ms to start would time out and be classified "ok" instead of "crashed"/"exited"). **Fix:** Bump the timeout argument in the non-"ok" spawn test cases from 0.3–0.5 s to 1–2 s. The "ok" (timeout) path can stay at 0.3 s since timing out _means_ success there. Relevant tests: `test_spawn_test_crashed`, `test_spawn_test_exited_cleanly`, `test_spawn_test_stderr_captured` in `tests/test_core.py`.

the_og added the P0 label 2026-07-02 01:05:57 -04:00

the_og referenced this issue

2026-07-02 01:06:23 -04:00

feat: stdio server spawn-test (#2) #11

the_og referenced this issue

2026-07-02 16:28:23 -04:00

[#1r] Secret-in-args warning badge #1

the_og referenced this issue from a commit

2026-07-04 13:12:05 -04:00

fix: bump spawn-test timeouts to avoid CI flakiness (closes #12)

the_og closed this issue

2026-07-04 13:12:05 -04:00