The crashed/exited tests use 0.3–0.5 s timeouts, which can misfire on a slow CI runner where Python interpreter startup takes longer than expected (a subprocess that takes >300 ms to start would time out and be classified "ok" instead of "crashed"/"exited").
Fix: Bump the timeout argument in the non-"ok" spawn test cases from 0.3–0.5 s to 1–2 s. The "ok" (timeout) path can stay at 0.3 s since timing out means success there.
Relevant tests: test_spawn_test_crashed, test_spawn_test_exited_cleanly, test_spawn_test_stderr_captured in tests/test_core.py.
Follow-up from PR #11 supervisor review (item 3).
The crashed/exited tests use 0.3–0.5 s timeouts, which can misfire on a slow CI runner where Python interpreter startup takes longer than expected (a subprocess that takes >300 ms to start would time out and be classified "ok" instead of "crashed"/"exited").
**Fix:** Bump the timeout argument in the non-"ok" spawn test cases from 0.3–0.5 s to 1–2 s. The "ok" (timeout) path can stay at 0.3 s since timing out _means_ success there.
Relevant tests: `test_spawn_test_crashed`, `test_spawn_test_exited_cleanly`, `test_spawn_test_stderr_captured` in `tests/test_core.py`.
the_og
added the P0 label 2026-07-02 01:05:57 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follow-up from PR #11 supervisor review (item 3).
The crashed/exited tests use 0.3–0.5 s timeouts, which can misfire on a slow CI runner where Python interpreter startup takes longer than expected (a subprocess that takes >300 ms to start would time out and be classified "ok" instead of "crashed"/"exited").
Fix: Bump the timeout argument in the non-"ok" spawn test cases from 0.3–0.5 s to 1–2 s. The "ok" (timeout) path can stay at 0.3 s since timing out means success there.
Relevant tests:
test_spawn_test_crashed,test_spawn_test_exited_cleanly,test_spawn_test_stderr_capturedintests/test_core.py.