fix: only advance update/lastCheck after a completed check (#37)
Closes #37 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1511,14 +1511,16 @@ class MainWindow(QMainWindow):
|
|||||||
last = float(st.value("update/lastCheck", 0.0, type=float) or 0.0)
|
last = float(st.value("update/lastCheck", 0.0, type=float) or 0.0)
|
||||||
if (time.time() - last) < 86400: # at most once/day
|
if (time.time() - last) < 86400: # at most once/day
|
||||||
return
|
return
|
||||||
st.setValue("update/lastCheck", time.time())
|
|
||||||
self._startup_update_worker = UpdateCheckWorker()
|
self._startup_update_worker = UpdateCheckWorker()
|
||||||
self._startup_update_worker.done.connect(self._on_startup_update_checked)
|
self._startup_update_worker.done.connect(self._on_startup_update_checked)
|
||||||
self._startup_update_worker.start()
|
self._startup_update_worker.start()
|
||||||
|
|
||||||
def _on_startup_update_checked(self, release: dict | None):
|
def _on_startup_update_checked(self, release: dict | None):
|
||||||
self._startup_update_worker = None
|
self._startup_update_worker = None
|
||||||
if release and core.is_newer_version(core.__version__, release["version"]):
|
if release is None:
|
||||||
|
return # offline/failed check: don't advance lastCheck, allow retry
|
||||||
|
QSettings("BCC", "BetterClaudeConfig").setValue("update/lastCheck", time.time())
|
||||||
|
if core.is_newer_version(core.__version__, release["version"]):
|
||||||
self.status.setText(
|
self.status.setText(
|
||||||
f"Update available: {release['version']} · Help ▸ About to view it."
|
f"Update available: {release['version']} · Help ▸ About to view it."
|
||||||
)
|
)
|
||||||
|
|||||||
Reference in New Issue
Block a user