feat(#101): live hot-reload of external sidecar/config changes
CI / Lint (ruff) (pull_request) Successful in 13s
CI / Tests (py3.12 / windows-latest) (pull_request) Successful in 25s
CI / Tests (py3.10 / ubuntu-latest) (pull_request) Successful in 20s
CI / Tests (py3.12 / ubuntu-latest) (pull_request) Successful in 13s
CI / Tests (py3.13 / ubuntu-latest) (pull_request) Successful in 12s
CI / Catalog signature (pull_request) Successful in 8s
CI / Lint (ruff) (pull_request) Successful in 13s
CI / Tests (py3.12 / windows-latest) (pull_request) Successful in 25s
CI / Tests (py3.10 / ubuntu-latest) (pull_request) Successful in 20s
CI / Tests (py3.12 / ubuntu-latest) (pull_request) Successful in 13s
CI / Tests (py3.13 / ubuntu-latest) (pull_request) Successful in 12s
CI / Catalog signature (pull_request) Successful in 8s
Detection (#91/#93) previously ran only at profile load / server selection, so a config.toml created or chmod-ed while BCC was running stayed invisible until a restart. Make the view react on its own. Core (pure, unit-tested — CI has no PySide6): - sidecar_watch_paths(): the external paths worth watching for a server — the resolved sidecar file, its directory (so create/delete and atomic-rename replaces register), and the wrong-path/doc file — order- stable and de-duplicated. - sidecar_state_fingerprint(): a hashable snapshot folding the #91 sidecar status and #93 permission status, so the GUI can tell whether the *observable* state actually changed and skip a redundant refresh. - sidecar_state_changed(): explicit, named equality for that decision. GUI (thin wiring, smoke-tested headlessly): - QFileSystemWatcher over the selection's sidecar path(s) + BCC's own loaded config; debounced (300 ms) so a burst of writes doesn't thrash. - Re-arm on every event: an atomic-rename replace drops the inode from the watcher, so wanted paths are re-added before the next check. - Focus-in fallback via changeEvent(ActivationChange) — always works where watchers miss (atomic replaces, not-yet-created files). - recheck_advisories() only recomputes warning labels from the form + filesystem; it never touches field values, so a live reload cannot clobber unsaved edits. - An external edit to BCC's own config surfaces a non-destructive Reload banner (never a silent overwrite); confirm-on-dirty reuses the existing load path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
cdda60da1b
commit
ded1eef2dd
@@ -16,7 +16,18 @@ import time
|
||||
from pathlib import Path
|
||||
from typing import ClassVar
|
||||
|
||||
from PySide6.QtCore import QRect, QSettings, QSize, Qt, QThread, QTimer, QUrl, Signal
|
||||
from PySide6.QtCore import (
|
||||
QEvent,
|
||||
QFileSystemWatcher,
|
||||
QRect,
|
||||
QSettings,
|
||||
QSize,
|
||||
Qt,
|
||||
QThread,
|
||||
QTimer,
|
||||
QUrl,
|
||||
Signal,
|
||||
)
|
||||
from PySide6.QtGui import (
|
||||
QAction,
|
||||
QActionGroup,
|
||||
@@ -1125,6 +1136,17 @@ class ServerEditor(QFrame):
|
||||
self.refresh_dependency(auto_open=False)
|
||||
self._check_args()
|
||||
|
||||
def recheck_advisories(self):
|
||||
"""Re-run the read-only sidecar / permission advisories (#101 hot-reload).
|
||||
|
||||
Public entry point for the file-watcher and focus-in fallback: it only
|
||||
recomputes the warning labels from the current form + the filesystem — it
|
||||
never touches the form's field values, so it is safe to call regardless of
|
||||
unsaved edits (it can't clobber them). Delegates to the same recompute the
|
||||
editor runs on every field change.
|
||||
"""
|
||||
self._check_args()
|
||||
|
||||
# --- args sanity check ------------------------------------------------ #
|
||||
def _current_arg_lines(self) -> list[str]:
|
||||
return [ln for ln in self.args.toPlainText().splitlines() if ln.strip() != ""]
|
||||
@@ -2180,6 +2202,18 @@ class MainWindow(QMainWindow):
|
||||
self._test_all_done = 0
|
||||
self._health_tester: SpawnTester | None = None
|
||||
|
||||
# Hot-reload (#101): watch the selected server's external sidecar path(s)
|
||||
# and BCC's own loaded config, so changes made outside BCC surface without
|
||||
# a restart. The watcher fires the debounce timer; the timer re-checks.
|
||||
self._fs_watcher = QFileSystemWatcher(self)
|
||||
self._fs_watcher.fileChanged.connect(self._on_fs_signal)
|
||||
self._fs_watcher.directoryChanged.connect(self._on_fs_signal)
|
||||
self._fs_debounce = QTimer(self)
|
||||
self._fs_debounce.setSingleShot(True)
|
||||
self._fs_debounce.setInterval(300) # coalesce a burst of writes
|
||||
self._fs_debounce.timeout.connect(self._recheck_external_state)
|
||||
self._sidecar_fp: tuple | None = None # last observed sidecar state
|
||||
|
||||
central = QWidget()
|
||||
self.setCentralWidget(central)
|
||||
root = QVBoxLayout(central)
|
||||
@@ -2202,6 +2236,12 @@ class MainWindow(QMainWindow):
|
||||
self.update_banner = NoticeBanner(self)
|
||||
root.addWidget(self.update_banner)
|
||||
|
||||
# External-change notice (#101): when BCC's own loaded config is edited
|
||||
# outside BCC, surface it here with a one-click Reload rather than
|
||||
# silently overwriting — a live reload must never clobber unsaved edits.
|
||||
self.reload_banner = NoticeBanner(self)
|
||||
root.addWidget(self.reload_banner)
|
||||
|
||||
# User-draggable divider between the server list and the editor.
|
||||
split = QSplitter(Qt.Orientation.Horizontal)
|
||||
split.setChildrenCollapsible(False)
|
||||
@@ -2703,6 +2743,8 @@ class MainWindow(QMainWindow):
|
||||
self._health.clear() # health results are per-profile; a fresh load invalidates them
|
||||
self._refresh_sets_combo() # sets are per-config; repopulate from the loaded file
|
||||
self._refresh_tables(select_index=0 if self.servers else -1)
|
||||
self.reload_banner.hide() # loaded fresh: any external-change notice is now stale
|
||||
self._rewatch_paths() # watch this profile's config + the selection's sidecar (#101)
|
||||
self._update_status(saved=False)
|
||||
if repaired:
|
||||
self._mark_dirty()
|
||||
@@ -2993,6 +3035,120 @@ class MainWindow(QMainWindow):
|
||||
self.copy_btn.setEnabled(entry is not None and len(self.profiles) > 1)
|
||||
self.dup_btn.setEnabled(entry is not None)
|
||||
self.del_btn.setEnabled(entry is not None)
|
||||
self._rewatch_paths()
|
||||
|
||||
# --- hot-reload (#101) ------------------------------------------------- #
|
||||
def _watch_targets(self) -> list[Path]:
|
||||
"""Every external path worth watching for the current view.
|
||||
|
||||
BCC's own loaded config (+ its directory), plus the selected server's
|
||||
sidecar path(s) resolved from its ServerSpec. Directories are watched too
|
||||
so a file appearing/disappearing — which a watch on a not-yet-existent
|
||||
file would miss, and which an atomic-rename replace looks like — is still
|
||||
observed. All entries must exist for QFileSystemWatcher to accept them.
|
||||
"""
|
||||
targets: list[Path] = []
|
||||
if self.current_profile is not None:
|
||||
cfg = Path(self.current_profile.path)
|
||||
targets.append(cfg)
|
||||
targets.append(cfg.parent)
|
||||
if self.editor.isEnabled():
|
||||
data = self.editor.dump_data()
|
||||
targets.extend(core.sidecar_watch_paths(data))
|
||||
# De-dup, keep only paths that currently exist (the watcher rejects the
|
||||
# rest; the parent dir covers a not-yet-created file).
|
||||
seen: set[str] = set()
|
||||
out: list[Path] = []
|
||||
for p in targets:
|
||||
key = str(p)
|
||||
if key in seen:
|
||||
continue
|
||||
seen.add(key)
|
||||
if p.exists():
|
||||
out.append(p)
|
||||
return out
|
||||
|
||||
def _rewatch_paths(self):
|
||||
"""Point the watcher at the current targets and snapshot sidecar state.
|
||||
|
||||
Re-applied whenever the selection or the edited command/args change (which
|
||||
server is selected decides which sidecar to watch) and after a reload.
|
||||
"""
|
||||
watcher = self._fs_watcher
|
||||
existing = watcher.files() + watcher.directories()
|
||||
if existing:
|
||||
watcher.removePaths(existing)
|
||||
wanted = [str(p) for p in self._watch_targets()]
|
||||
if wanted:
|
||||
watcher.addPaths(wanted)
|
||||
self._sidecar_fp = self._current_sidecar_fp()
|
||||
|
||||
def _current_sidecar_fp(self) -> tuple | None:
|
||||
if not self.editor.isEnabled():
|
||||
return None
|
||||
return core.sidecar_state_fingerprint(self.editor.dump_data())
|
||||
|
||||
def _on_fs_signal(self, _path=None):
|
||||
"""A watched path changed — coalesce a burst of writes via the debounce."""
|
||||
self._fs_debounce.start()
|
||||
|
||||
def _recheck_external_state(self):
|
||||
"""Debounced re-check: re-arm the watcher, refresh advisories if state
|
||||
actually changed, and surface an external edit to BCC's own config.
|
||||
|
||||
Runs from both the file-watcher and the focus-in fallback. Never mutates
|
||||
the editor form or the loaded config — the only content reload is the
|
||||
user pressing Reload on the banner, so unsaved edits are safe.
|
||||
"""
|
||||
# Re-arm: an atomic-rename replace drops the old inode from the watcher,
|
||||
# so paths must be re-added or the next change goes unseen.
|
||||
self._rewatch_after_event()
|
||||
|
||||
# Sidecar/permission advisories for the selected server (#91/#93). Only
|
||||
# refresh when the observable state changed, so an unrelated write in the
|
||||
# watched directory doesn't thrash the panel.
|
||||
new_fp = self._current_sidecar_fp()
|
||||
if core.sidecar_state_changed(self._sidecar_fp, new_fp):
|
||||
self._sidecar_fp = new_fp
|
||||
self.editor.recheck_advisories()
|
||||
|
||||
# BCC's own loaded config edited outside BCC: surface it (non-destructive).
|
||||
self._check_config_changed_on_disk()
|
||||
|
||||
def _rewatch_after_event(self):
|
||||
"""Re-add any wanted paths the watcher dropped, without disturbing the
|
||||
sidecar fingerprint (which _recheck_external_state compares itself)."""
|
||||
watcher = self._fs_watcher
|
||||
current = set(watcher.files()) | set(watcher.directories())
|
||||
readd = [str(p) for p in self._watch_targets() if str(p) not in current]
|
||||
if readd:
|
||||
watcher.addPaths(readd)
|
||||
|
||||
def _check_config_changed_on_disk(self):
|
||||
if self.current_profile is None:
|
||||
return
|
||||
disk = core.config_fingerprint(self.current_profile.path)
|
||||
if disk is not None and self._loaded_stat is not None and disk != self._loaded_stat:
|
||||
self.reload_banner.show_notice(
|
||||
f"{self.current_profile.path} changed on disk (edited outside BCC).",
|
||||
action_label="Reload from disk",
|
||||
on_action=lambda: self.load_profile(self.current_profile, confirm=True),
|
||||
)
|
||||
else:
|
||||
# Back in sync (e.g. the user reloaded, or the change was reverted).
|
||||
self.reload_banner.hide()
|
||||
|
||||
def changeEvent(self, event):
|
||||
"""Re-check external state when the window regains focus (#101).
|
||||
|
||||
A cheap, always-works fallback: QFileSystemWatcher can miss changes
|
||||
(notably atomic-rename replaces, and files that didn't exist when the
|
||||
watch was set), so a re-check on activation covers the gap.
|
||||
"""
|
||||
if event.type() == QEvent.Type.ActivationChange and self.isActiveWindow():
|
||||
# Go through the debounce so activation + a watcher signal coalesce.
|
||||
self._fs_debounce.start()
|
||||
super().changeEvent(event)
|
||||
|
||||
def _table_item_changed(self, item: QTableWidgetItem):
|
||||
if self._suppress_table or item.column() != 0:
|
||||
@@ -3047,6 +3203,9 @@ class MainWindow(QMainWindow):
|
||||
health_item.setToolTip("Not tested since last edit.")
|
||||
self._suppress_table = False
|
||||
self._refresh_badges()
|
||||
# The edited command/args may change which package (and thus which
|
||||
# sidecar) this server resolves to — re-point the watcher (#101).
|
||||
self._rewatch_paths()
|
||||
self._mark_dirty()
|
||||
|
||||
# --- server actions -------------------------------------------------- #
|
||||
|
||||
Reference in New Issue
Block a user