Merge pull request 'fix: only advance update/lastCheck after a completed check (#37)' (#44) from fix/37-update-lastcheck into main

2026-07-12 13:00:36 -04:00
parent 6dacc26057 f5c9780948
commit 6a91f830dc
1 changed files with 4 additions and 2 deletions
@@ -1543,14 +1543,16 @@ class MainWindow(QMainWindow):
        last = float(st.value("update/lastCheck", 0.0, type=float) or 0.0)
        if (time.time() - last) < 86400:  # at most once/day
            return
-        st.setValue("update/lastCheck", time.time())
        self._startup_update_worker = UpdateCheckWorker()
        self._startup_update_worker.done.connect(self._on_startup_update_checked)
        self._startup_update_worker.start()

    def _on_startup_update_checked(self, release: dict | None):
        self._startup_update_worker = None
-        if release and core.is_newer_version(core.__version__, release["version"]):
+        if release is None:
+            return  # offline/failed check: don't advance lastCheck, allow retry
+        QSettings("BCC", "BetterClaudeConfig").setValue("update/lastCheck", time.time())
+        if core.is_newer_version(core.__version__, release["version"]):
            self.status.setText(
                f"Update available: {release['version']}  ·  Help ▸ About to view it."
            )