the_og/better-claude-config
1
0
Fork 0
Code Issues 8 Pull Requests 3 Actions Packages Projects Releases 4 Wiki Activity

Merge pull request 'fix: only advance update/lastCheck after a completed check (#37)' (#44) from fix/37-update-lastcheck into main
CI / Lint (ruff) (push) Successful in 7s
Details
CI / Tests (py3.10) (push) Successful in 9s
Details
CI / Tests (py3.12) (push) Successful in 10s
Details

Browse Source
This commit was merged in pull request #44.
This commit is contained in:
the_og
2026-07-12 13:00:36 -04:00
parent 6dacc26057 f5c9780948
commit 6a91f830dc
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bcc.py
+4 -2
View File
@@ -1543,14 +1543,16 @@ class MainWindow(QMainWindow):
last = float(st.value("update/lastCheck", 0.0, type=float) or 0.0) last = float(st.value("update/lastCheck", 0.0, type=float) or 0.0)
if (time.time() - last) < 86400: # at most once/day if (time.time() - last) < 86400: # at most once/day
return return
st.setValue("update/lastCheck", time.time())
self._startup_update_worker = UpdateCheckWorker() self._startup_update_worker = UpdateCheckWorker()
self._startup_update_worker.done.connect(self._on_startup_update_checked) self._startup_update_worker.done.connect(self._on_startup_update_checked)
self._startup_update_worker.start() self._startup_update_worker.start()
def _on_startup_update_checked(self, release: dict | None): def _on_startup_update_checked(self, release: dict | None):
self._startup_update_worker = None self._startup_update_worker = None
if release and core.is_newer_version(core.__version__, release["version"]): if release is None:
return # offline/failed check: don't advance lastCheck, allow retry
QSettings("BCC", "BetterClaudeConfig").setValue("update/lastCheck", time.time())
if core.is_newer_version(core.__version__, release["version"]):
self.status.setText( self.status.setText(
f"Update available: {release['version']} · Help ▸ About to view it." f"Update available: {release['version']} · Help ▸ About to view it."
) )